-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New "canard" button #758
New "canard" button #758
Conversation
An additional colour for the buttons, based on the graphic charter of the EPFL; red is sometimes perceived as "too aggressive".
Test Results 1 files 1 suites 0s ⏱️ For more details on these errors, see this check. Results for commit 62ff987. ♻️ This comment has been updated with latest results. |
🔎 Download the Backstop report for this pull request (link valid for 90 days): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
La couleur $leman n'a pas un contraste suffisant avec le texte blanc (voir le tableau dans le styleguide). Il faudrait soit utiliser la couleur $canard qui est ok, soit définir une variante $leman-dark qui aurait un contraste suffisant avec le blanc. Par exemple la teinte #00827C serait ok.
- switched $leman to $canard - added $canard-dark color
Caramba, comment ais-je pu oublier de vérifier ça? 🫣 Merci. Partons alors sur la couleur $canard. J'ai également défini une variante $canard-dark (spéciale Haloween) avec une teinte #004248. N'hésite pas à proposer mieux! |
C'est parfait ! Je valide la couleur canard de Halloween 😄 |
An additional colour for the buttons, based on the graphic charter of the EPFL; red is sometimes perceived as "too aggressive".